code reviews

Farfetch · Oct 13, 2023 · ba50742 · ba50742
1 parent ea13246
commit ba50742
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs b/src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
@@ -26,8 +26,6 @@ public static Task OnProducerStarted(IMessageContext context)
                 // https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md
                 var activity = ActivitySourceAccessor.ActivitySource.StartActivity(activityName, ActivityKind.Producer);
 
-                context?.Items.Add(ActivitySourceAccessor.ActivityString, activity);
-
                 // Depending on Sampling (and whether a listener is registered or not), the
                 // activity above may not be created.
                 // If it is created, then propagate its context.
@@ -36,6 +34,8 @@ public static Task OnProducerStarted(IMessageContext context)
 
                 if (activity != null)
                 {
+                    context?.Items.Add(ActivitySourceAccessor.ActivityString, activity);
+
                     contextToInject = activity.Context;
                 }
                 else if (Activity.Current != null)