Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump kafkaflow version to "3.0.0" #144

Merged
merged 4 commits into from
Dec 15, 2023
Merged

build(deps): bump kafkaflow version to "3.0.0" #144

merged 4 commits into from
Dec 15, 2023

Conversation

gsferreira
Copy link
Contributor

@gsferreira gsferreira commented Dec 4, 2023 •
edited
Loading

Description

  • Upgrade to KafkaFlow 3.0.
  • Update Quickstart according to KafkaFlow 3.0
  • Refactor DboConfigurations.cs to fix a flaky test.
  • Replace System.Data.SqlClient with Microsoft.Data.SqlClient (see here why)
    • Breaking Change: In System.Data.SqlClient the Encrypt defaults to false and that has changed in Microsoft.Data.SqlClient (here)

Fixes #143

How Has This Been Tested?

Run tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@gsferreira gsferreira marked this pull request as ready for review December 6, 2023 10:14
@gsferreira gsferreira marked this pull request as draft December 12, 2023 09:56
@gsferreira gsferreira marked this pull request as ready for review December 12, 2023 13:12
luispfgarces
luispfgarces approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@luispfgarces luispfgarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your changes @gsferreira 🙏 let's go with them 🙂

@luispfgarces luispfgarces merged commit 9ee2ed2 into main Dec 15, 2023
3 checks passed
@luispfgarces luispfgarces deleted the upgrade-kafkaflow-v3 branch December 15, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luispfgarces luispfgarces luispfgarces approved these changes

@carlosgoias carlosgoias carlosgoias approved these changes

@fernando-a-marins fernando-a-marins Awaiting requested review from fernando-a-marins

@Daniel-C-Dias Daniel-C-Dias Awaiting requested review from Daniel-C-Dias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update to use KafkaFlow 3.0.0
4 participants
@gsferreira @carlosgoias @luispfgarces @fernando-a-marins