Fix tictactoe reset bug (when one agent died) #1229
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a tictactoe environment
env
, ifenv
get resetted when an possible agent is not in theenv.agents
list (for invalid action or other reasons), that agent would not be selected forever, sinceenv._agent_selector
always gets re-initialized with the listenv.agent
which misses that agent. To fix this situation,env._agent_selector
should get re-initialized withenv.possible_agents
(which contains all possible agents.) rather thanenv.agents
.Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.Format YAML files.
failed.pytest -v
has generated that are related to my code to the best of my knowledge.