Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Gymnasium to 1.0.0 and NumPy to 2.0.0+ #453

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Upgraded Gymnasium to 1.0.0 and NumPy to 2.0.0+ #453

wants to merge 9 commits into from

Conversation

BolunDai0216
Copy link
Collaborator

Description

This PR updates Minigrid to support Gymnasium 1.0.0 and NumPy 2.0 (tested with 2.1.2).

Fixes # (issue)

#452

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@BolunDai0216 BolunDai0216 mentioned this pull request Oct 22, 2024
Open
pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you update the version number and doctest seems to be failing because of NumPy 2.0 changed the format for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BolunDai0216 @pseudo-rnd-thoughts