Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit autoupdate #214

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pseudo-rnd-thoughts
Copy link
Member

Description

I noticed that pyupgrade was using py-37 style which I updated to py-38 and pre-commit autoupdate more generally which causes a number of automated changes

@younik
Copy link
Member

younik commented Jul 2, 2024

I don't understand where the error comes from. It looks like assert isinstance(env, gym.Env) doesn't exclude that env can be a string or None.

Moreover, the syntax a: Type1 | Type2 requires Python >=3.10, isn't it? Because we are currently supporting >=3.8

@pseudo-rnd-thoughts
Copy link
Member Author

Moreover, the syntax a: Type1 | Type2 requires Python >=3.10, isn't it? Because we are currently supporting >=3.8

I believe we can add from __future__ import annotation to fix that issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants