[Bug Fix] Fix h5py group creation

[rodrigodelazcano]

Description

While creating a dataset I got an error due to a simplification in this previous PR #102 to create non-existing h5py groups. It appears that this code doesn't work as I thought. The following code is an example that we can't check for existing/non-existing groups and create the group as default with the get function in h5py:

import h5py


with h5py.File('testing_file.hdf5', 'a') as f:

    f.create_group('new_group')

    group = f.get('new_group', default=f.create_group('new_group'))

The code will throw an error saying that the group already exists.

My proposed fix is a function to implement the previous functionality from the mentioned PR (#102)

Checklist:

• I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
• I have run pytest -v and no errors are present.
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[balisujohn]

Is there a test that could be added that would test this behavior? If so, I think that test should be added. Otherwise, LGTM

[younik]

Ah, my bad! The function is called even if the key exists; thanks for fixing this

[rodrigodelazcano]

Is there a test that could be added that would test this behavior? If so, I think that test should be added. Otherwise, LGTM

Lets add the test in another PR so that we can move forward with the next release of Minari

[balisujohn]

LGTM :^)