Temporary fix for CI failing on all_close call checking repeated environment resets
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To confirm this is a permanent fix? |
|
@pseudo-rnd-thoughts This is a temporary fix. We need to spend some time reviewing the tests, I just don't have the bandwidth right now. This temporary change should allow for CI to pass consistently until we revamp the tests |
pseudo-rnd-thoughts
changed the title
all_close call checking repeated environment resets
pseudo-rnd-thoughts
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to CI changes the looseness of the "all_close" call when ensuring that observations are the same across environment resets. This is a logged issue (Issue #443) and will be dealt with accordingly. It's most likely due to changes in Mujoco bindings.