Fixing missing number of steps check #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pseudo-rnd-thoughts actually, do you have any thoughts about removing this value error and returning truncated=True? That way we don't need to wrap any Meta-World environment in a TimeLimit wrapper or keep track of the number of steps. |
| @@ -459,6 +459,8 @@ def step(self, action): | |||
| assert len(action) == 4, f"Actions should be size 4, got {len(action)}" | |||
| self.set_xyz_action(action[:3]) | |||
| self.do_simulation([action[-1], -action[-1]], n_frames=self.frame_skip) | |||
| if getattr(self, 'curr_path_length', 0) > self.max_path_length: | |||
There was a problem hiding this comment.
Why are we using 'getattr' for this?
|
I'm a bit confused on the structure of the metaworld environments, is there a technical description anywhere? |
|
I copied the code that got removed from the modified MuJoco env to the Sawyer base class. We can remove this value error if we set truncated=True when the max number of steps has been hit? Unfortunately I don't think there's any great documentation on the environments themselves |
|
@pseudo-rnd-thoughts I removed the use of getattr |
pseudo-rnd-thoughts
approved these changes
Aug 9, 2023
reginald-mclean
merged commit 15f269b
into
Farama-Foundation:master
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original repo, the do_simulation function in the modified mujoco env had a check for the maximum number of steps per env. This was added back in now that Meta-World uses the Mujoco Env in Gymnasium