Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding three different mo-mountain-car environments #97

Merged

Conversation

pranavg23
Copy link
Contributor

Environments added with relevant comments:
1)Time-Speed (2 Objectives)
2)Time-Movement (2 Objectives)
3)Time-Movement-Speed (3 Objectives)

@LucasAlegre LucasAlegre self-assigned this Aug 5, 2024
@LucasAlegre LucasAlegre added the enhancement New feature or request label Aug 5, 2024
@LucasAlegre
Copy link
Member

@pranavg23 I simplified the code since the computation of the rewards was very simple. Can you check if this is still equivalent to your version?

@pranavg23
Copy link
Contributor Author

pranavg23 commented Aug 7, 2024

The 3 objective setting has a merged movement objective and a speed objective, while I think the change you made, adds just a speed objective which would make it 4 objective. @LucasAlegre

No reward setting has forward and backward rewards, they are either combined or removed (time-speed) case, since they give rise to the local optima due to a lack of reward signal for the static action

@LucasAlegre
Copy link
Member

@pranavg23 thanks! I think I fixed it in the last commit. Could you double-check?

@pranavg23
Copy link
Contributor Author

@pranavg23 thanks! I think I fixed it in the last commit. Could you double-check?

Just checked, all good!

@LucasAlegre LucasAlegre merged commit 0ec9b86 into Farama-Foundation:main Aug 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants