Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pusher-v5 model to one that is compatible with mujoco>=3 #1019

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

increased the weight of the object to 7.85398163e-06 kg from 1.30899694e-08 kg (500x increase)

Fixes #950

testing & validation was done using: https://github.com/Kallinteris-Andreas/Gymnasium-Pusher-v5-model-validation

credits

@Kallinteris-Andreas

and thanks to @HernandezEduin, for initial testing

Type of change

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a warning to the version history of v4

@Kallinteris-Andreas
Copy link
Collaborator Author

There is now a warning for v4 and mujoco>=3 in the documentation for users using gymnasium<=1.0.0a1, for future users are not about to instantiate the environment with an incompatible versions for mujoco

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review April 17, 2024 07:04
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit b6d7f51 into main Apr 17, 2024
16 checks passed
@Kallinteris-Andreas Kallinteris-Andreas mentioned this pull request Apr 23, 2024
35 tasks
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the Kallinteris-Andreas-patch-7 branch May 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Problems with Collisions in Pusher-v4
2 participants