Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit mujoco<3.0 #187

Merged
merged 7 commits into from
Oct 19, 2023

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Oct 19, 2023

Description

title says it all

@Kallinteris-Andreas Kallinteris-Andreas changed the title limit mujoco<=3.0 limit mujoco<3.0 Oct 19, 2023
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft October 19, 2023 12:37
@rodrigodelazcano
Copy link
Member

Thanks. Can you make the same PR in Gymnasium while we validate the changes for the Swimmer xml

Copy link
Member

@rodrigodelazcano rodrigodelazcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you fix the comments?

pyproject.toml Outdated
@@ -24,7 +24,7 @@ classifiers = [
'Topic :: Scientific/Engineering :: Artificial Intelligence',
]
dependencies = [
"mujoco>=2.3.3",
"mujoco>=2.3.3<3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ,: "mujoco>=2.3.3, <3.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mujoco>=2.3.3 should be kept as well

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated
@@ -24,7 +24,7 @@ classifiers = [
'Topic :: Scientific/Engineering :: Artificial Intelligence',
]
dependencies = [
"mujoco>=2.3.3",
"mujoco>=2.3.3, <3.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another missing , after the mujoco version specifiers

@rodrigodelazcano rodrigodelazcano marked this pull request as ready for review October 19, 2023 17:26
@rodrigodelazcano rodrigodelazcano merged commit 8e9a3be into Farama-Foundation:main Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants