-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit mujoco<3.0
#187
limit mujoco<3.0
#187
Conversation
Thanks. Can you make the same PR in Gymnasium while we validate the changes for the Swimmer xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you fix the comments?
pyproject.toml
Outdated
@@ -24,7 +24,7 @@ classifiers = [ | |||
'Topic :: Scientific/Engineering :: Artificial Intelligence', | |||
] | |||
dependencies = [ | |||
"mujoco>=2.3.3", | |||
"mujoco>=2.3.3<3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ,
: "mujoco>=2.3.3, <3.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mujoco>=2.3.3
should be kept as well
pyproject.toml
Outdated
@@ -24,7 +24,7 @@ classifiers = [ | |||
'Topic :: Scientific/Engineering :: Artificial Intelligence', | |||
] | |||
dependencies = [ | |||
"mujoco>=2.3.3", | |||
"mujoco>=2.3.3, <3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another missing ,
after the mujoco version specifiers
Description
title says it all