Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Carmen Race-Detection test #135

Closed
wants to merge 1 commit into from
Closed

Conversation

cabrador
Copy link
Contributor

@cabrador cabrador commented Sep 11, 2024

This PR changes worker in Carmens race-detection test from db-small-ssd to db-small-nvme.

This test started failing on out of memory issue. nvme worker has slightly higher memory than ssd and fixes this issue.

In future we should divide db-small-ssd worker into one with small memory and other with higher memory.
Issue: #134

Copy link
Collaborator

@kjezek kjezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that there was no higher memory consumption introduced in Carmen? Unless there was no recent hardware change in small-db-ssd, it points at a problem in Carmen, because this pipeline used to work. What is hardware conf. of this node? 32GB?

@kjezek
Copy link
Collaborator

kjezek commented Sep 12, 2024

Also I think we should have pipelines running on a moderate hardware. We had feedback about too much memory consumed by Carmen, and if we run always on a generous RAM allowance, a high memory consumption stays unnoticed.

@cabrador
Copy link
Contributor Author

As discussed in private conversation - this error should be solved on Carmen side by reducing memory leaks in tests.

@cabrador cabrador closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants