-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Opporozidone and ReduceRotting Effect #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seem good due i think this PR seem better in EE, also upsteam is EE not wizden.
I hope all positions are correct or were gona have pain with upstream merges.
Oh, if Oppo is in upstream EE I can see about remaking what I did for what they did, if that works. I did PR this fully myself from Wizden upstream so I can do this again with EE upstream this time. |
Currently EE does not have those changes, feel free to PR it to EE, this PR is fine also. |
Wait, nevermind, I misread what you meant. I feel afraid to do a PR to EE but I might give it a shot, Also, what do you mean by positions? Still learning most terms and how things work. |
I mean by position is that we avoid when EE has the feature to have double the code or something making conflicts, and dont worry about EE, a bunch of friendly bloke who loves birds... |
Alright, I might give it a shot then! hopefully I can figure out how to get these changes over to EE. |
@FoxxoTrystan Do we actually have to do it this way. We could just merge it here, and upstream can pull the changes. If we use git properly nothing should change. |
Ye i still approve the changes here, just saying all the above. |
Description
Added Opporozidone, the chemical that reduces rot, from upsteam! Allows people to be revived even if their bodies are rotting, which reduces the use of cloning and losing your character. The code for this may be a bit botched, as I patched in the Wizden code, which required adding a method from upstream to the sharedRottingSystem. Not sure if it was the right place to put it but the chemical DOES work, so.
Media
Changelog
🆑 Xavier