Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Vent Critters #435

Merged

Conversation

Mnemotechnician
Copy link
Collaborator

Description

Adds a double random delay to the vent critters rule, as well as optional sounds and popups. Also prevents the gamerule from spawning mobs on welded vents, implements the framework for delayed spawn for use in other entity systems, fixes some ftl problems (including the missing announcement for spider clowns)

Media

weeee-2024-12-27_05.52.32.mp4

Changelog

🆑

  • add: Vent critters will no longer spawn immediately after being announced, and their appearance is now accompanied by audiovisual warnings appearing up to 6 seconds ahead of their spawn.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 27, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Better vent critters Better Vent Critters Dec 27, 2024
@Mnemotechnician
Copy link
Collaborator Author

It would appear the audio system's PlayStatic method ignores the SoundParams argument. That is sad and there's nothing I can do until an engine update fixes it (hopefully).

@Fansana Fansana merged commit 7e7cd09 into Fansana:master Dec 27, 2024
11 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants