Add Codeword Highlighting (#30092) #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added codeword highlighting * Updated to support more codeword roles, color is set serverside * Review feedback * Change to a Component-based system using SessionSpecific * Tidied up CanGetState, set Access restrictions on component * Clean-up * Makes the injection ignore brackets, restore some codewords, remove "Taste/Touch" from adjectives (cherry picked from commit 61a1e89339d0187f1a59b37284108935669c6826)
github-actions
bot
added
Status: Needs Review
Floof-Station-Bot
changed the title
Mnemotechnician
approved these changes
Dec 23, 2024
| [DataField, AutoNetworkedField] | ||
| public Dictionary<string, CodewordsData> RoleCodewords = new(); | ||
|
|
||
| public override bool SessionSpecific => true; |
There was a problem hiding this comment.
Would be better to have SendOnlyToOwner => true instead of reinventing the wheel here and in OnCodewordCompGetStateAttempt, but if it works, it works.
There was a problem hiding this comment.
I mean we can improve on it but it's straight from wizden so I don't really wanna mess with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑