Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Conditions #418

Merged

Conversation

Mnemotechnician
Copy link
Contributor

Description

Implements some basic framework for customizable event conditions (currently featuring 3 types of conditions: job count condition, departament count condition, and complex condition - boolean and/or), and adds:

  • A condition for at least 2 security players for most midround antags
  • A condition for at least 2 enineering players for meteor swarms
  • A condition for at least 1 epistemics player for random anomaly spawn

The existing conditions determine a player's job by first performing an inverse lookup by their ID title, and then, if it fails, checking the job they took when joining the station (dictated by the JobComponent on their mind. It's extremely dumb, I know, but neither ID cards nor player entities actually store your current job)

This needs further testing and adjustments.

Media

Something something I'm struggling to test it locally because I can't really run more than 2 clients at once.

image


Changelog

🆑

  • add: Station events can now have customizable conditions. This means that the station will no longer have to suffer from midround antags when there is zero security players, and the like.

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files labels Dec 16, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Event conditions Event Conditions Dec 16, 2024
Copy link
Collaborator

@Memeji Memeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're amazing

@FoxxoTrystan FoxxoTrystan merged commit 45849fb into Fansana:master Dec 21, 2024
17 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants