More Leash Tweaks #414
Merged
More Leash Tweaks #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mnemotechnician
requested review from
Fansana,
Memeji and
FoxxoTrystan
as code owners
github-actions
bot
added
Status: Needs Review
FoxxoTrystan
approved these changes
Dec 15, 2024
Floof-Station-Bot
added a commit
that referenced
this pull request
Dec 15, 2024
sleepyyapril
added a commit
to TheDenSS14/TheDen
that referenced
this pull request
Jan 5, 2025
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> adds PR #414 from Floof Station Fansana/floofstation1#414 - Leashes now have configurable length. You can choose the preferred length in the verb menu. - The short leash proto has been removed and an appropriate prototype migration has been added. - Leashes were made anchorable (so we can finally keep Seb safe) - Leash sprites were visually scaled down (70% the original size) - Shock and bell collars have been reparented to ClothingNeckCollarBase. - Leash anchors now a visual offset field, that properly incorporates the visual rotation and scaling of the entity. - Leashes now use a brand new overlay renderer (a refactored JointVisualsOverlay) - Fixed a bug where the "remove leash" verb would not appear on the respective clothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This performs the following changes:
Also performed some cleanup and refactor.
If someone wants to bother, they can adjust the leash anchor offsets on station pets; The existing system should properly support those. I don't have the mental capacity to do it right now, though, so only collars and scugcats have proper offsets.
Media
Anchorability:
weeee-2024-12-15_22.15.37.mp4
Demonstrating configurable lengths:
god.I.hate.naming.mp4
Changelog
🆑