Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-Enable Language Color and Font (#1294) #412

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Re-Enable Language Color and Font (#1294) #412

merged 1 commit into from
Dec 15, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Dec 15, 2024

🆑

  • fix: language markers

@angelofallars @Fansana
Re-Enable Language Color and Font (#1294)
685c0c9 
# Description

Re-enables language font and colors showing up in chat messages. The
language font/colors were bugged after adding language names in chat
(Simple-Station/Einstein-Engines#1165)

I also overhauled the format for chat messages to be more aesthetically
pleasing, and made sure chat bubbles use the language color/font.

## Media

**Nekomimetic**

![image](https://github.com/user-attachments/assets/4cb88d7b-7466-42ed-bf2d-b68c68edb62c)

![image](https://github.com/user-attachments/assets/adec7fd7-0a84-4e21-9eff-c1a387e2d529)

**Bubblish**

![image](https://github.com/user-attachments/assets/c49f5573-ac96-4375-a584-e8b2cc6f5fee)

![image](https://github.com/user-attachments/assets/c739c249-9d1e-453e-9e92-3f7ef24a4d61)

**Tau-Ceti Basic (Default Language)**

![image](https://github.com/user-attachments/assets/e6660039-ac2f-449b-96e0-44e0142d3715)

![image](https://github.com/user-attachments/assets/2baec2ca-975d-4111-85b0-3b2056fdd7f7)

**Rootspeak**

![image](https://github.com/user-attachments/assets/99d94f8d-9a1c-4be9-8c98-b42c9c7cffd7)

![image](https://github.com/user-attachments/assets/c20b4621-1ca7-42f5-a22a-82c9a4d1dddf)

## Changelog

:cl: Skubman
- fix: Language colors and fonts will show up in text messages again,
both on in-person messages and on the radio.
- tweak: The text on chat bubbles now uses the color and font of the
language being spoken.
- tweak: The language prefix before the name on chat messages now uses
the language's color.

(cherry picked from commit 1a9763528a9b15f11f474a2fa7ecfdde98aa9a15)
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 15, 2024
@FoxxoTrystan FoxxoTrystan merged commit 227bc93 into master Dec 15, 2024
15 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 15, 2024
@Floof-Station-Bot
Automatic Changelog Update (#412)
0294500
@Fansana Fansana mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan approved these changes

@Memeji Memeji Awaiting requested review from Memeji Memeji is a code owner

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fansana @FoxxoTrystan @angelofallars