Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salvage Magnet UI and Character Switching Height/Width Bug Fix (#1347) #411

Merged
merged 4 commits into from
Dec 15, 2024

Conversation

Fansana
Copy link
Owner

@Fansana Fansana commented Dec 15, 2024

🆑

  • fix: Character UI scaling fixes
  • fix: fix Salvage magnet opening multiple windows

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

i fixed it

also added a button "Connect & Go to Lobby" for people testing lobby
stuff!

Resolves #1131

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed the bug where switching characters made your width/height
change to incorrect values.
- fix: Fixed the salvage magnet opening ten times.

---------

Signed-off-by: sleepyyapril <[email protected]>
(cherry picked from commit c4c3e4283ae077fd0f55e4cce31710f31de046f7)
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files labels Dec 15, 2024
@FoxxoTrystan
Copy link
Collaborator

Test fails are valid, reminder that EE has an updated engine version.

@FoxxoTrystan FoxxoTrystan merged commit 0cb2514 into master Dec 15, 2024
10 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 15, 2024
@Fansana Fansana mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants