Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Departament-Specific Lathes #342

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Mnemotechnician
Copy link
Collaborator

@Mnemotechnician Mnemotechnician commented Nov 10, 2024

Description

This brings back the service, engineering, and cargo techfabs, along with brand new listings and boards for them, and improves the secfab and the medfab.

The heads of the respective departaments get the respective techfab boards in their lockers. Whether they choose to let their whole dept access them, or just themselves, is up to them.


The service techfab is mostly used to produce various service tools, such as mops, spray bottles, speed boots, DAW & jukebox boards, station maps, etc

The engi techfab includes all static recipes of the autolathe, AND allows to manufacture most atmospheric machines, most generators, the power monitoring and atmos alert computers, shuttle things, etc. It can also make advanced tools, except for JoL which are too OP.

The cargo techfab includes all static recipes of the autolathe, as well as some cargo tools (mining drill, grapple, handheld mass scanner, tether guns (in case epi researches T3 experimental, cargo can put it to use for once. This is like the only practical use for those other than just goofing around).

The secfab can now make various surveillance boards, speed boots, jaws of life, impassable holobarrier projectors (T2 experimental), and more. I didn't add magboots to the list because there's another PR adding security-specific magboots.

The medfab can now make some stuff that may be useful for paramedics - station maps and the like, as well as the boards for some medical equipment - cloning machines and consoles, stationary crew monitor, etc. The cloning pod is not currently available as a research, so it's never going to actually be producible.

Epistemics still has their protolathe & curcuit imprinter, which are largerly unchanged, with the only exception of adding the atmos alert computer board to the circuit imprinter.


This PR also makes the atmospherics alert computer researchable and manufacturable, and adds the new boards to the random machine board pool.


The changes were made in the original files with the hope of backporting this to EE later on.


Media

image

image

image

image

image

image

image

image

Changelog

🆑

  • add: The heads of logistics, service, and engineering can now find brand-new department-specific techfab boards in their lockers.
  • add: The list of things the medical and security techfabs can produce has been expanded.

…pt-lathes

# Conflicts:
#	Resources/Prototypes/Entities/Structures/Machines/lathe.yml
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files labels Nov 10, 2024
@Mnemotechnician Mnemotechnician changed the title Floof/feat/dept lathes Feat: Departament-Specific Lathes Nov 10, 2024
@Fansana Fansana added the Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. label Nov 11, 2024
@FoxxoTrystan
Copy link
Collaborator

This is going under review in maintainer team but il say my personnal view on this, i dont like having too many lathe, autolathe seem to be the default that simply needed, then circuit printer should be used for all circuit (wait is circuit printer even a thing in the game yet?)

But again this is gona go under a maintainer review.

@FoxxoTrystan FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Nov 21, 2024
@FoxxoTrystan
Copy link
Collaborator

While this is good, im not a super fan of a lot of things slightly in there, notly circuits and engineer related builds in other lathes.

cricut printer should be prioritized for any circuit (exception on some), but then others lathe making circuits for me seems very very, meh...

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Nov 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@FoxxoTrystan
Copy link
Collaborator

Merge Conflicts but very intrested.

@Mnemotechnician
Copy link
Collaborator Author

Ugh, I'm gonna fix them quickly...

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Nov 28, 2024
Copy link
Collaborator

@Memeji Memeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Trystan, no map updates but that'll come later.
Looks great!

@Memeji Memeji merged commit 5f606ad into Fansana:master Dec 2, 2024
11 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants