fix test and migrate pom to Central

[gkorland]

Summary by CodeRabbit

• New Features

  • Updated project version to 0.4.0, enhancing overall functionality.
  • Improved dependency management with updated versions for key libraries.

• Bug Fixes

  • Adjusted test methods for better type handling and consistency.

• Documentation

  • Enhanced readability and formatting in the test suite for improved clarity.

[coderabbitai]

Walkthrough

The changes involve updates to the pom.xml file, including version increments for the project and several dependencies, as well as a switch from the nexus-staging-maven-plugin to the central-publishing-maven-plugin. Additionally, the GraphAPITest class has received formatting improvements and minor adjustments in method signatures and assertions to enhance code readability and accommodate different data types.

Changes

File Path	Change Summary
pom.xml	Project version updated to 0.4.0-SNAPSHOT. Dependency versions updated for commons-text and junit-jupiter. Replaced nexus-staging-maven-plugin with central-publishing-maven-plugin with new configuration parameters. Updated versions for maven-source-plugin, maven-javadoc-plugin, and maven-pmd-plugin.
src/test/java/com/falkordb/GraphAPITest.java	Whitespace adjustments, type changes in assertions, and formatting improvements in multiple test methods.

Poem

In the garden of code, where the bunnies play,
Versions bloom bright, chasing bugs away.
With plugins replaced and tests all aligned,
Our project hops forward, beautifully refined! 🐇✨
Readable code, like a soft, gentle breeze,
Brings joy to our hearts, puts our minds at ease!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cd92ff0 and 2285b92.

📒 Files selected for processing (2)

• pom.xml (7 hunks)
• src/test/java/com/falkordb/GraphAPITest.java (5 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/test/java/com/falkordb/GraphAPITest.java

🧰 Additional context used

🔇 Additional comments (8)

pom.xml (8)

14-14: Version update looks good. Please clarify the release plan.

The project version has been updated from 0.3.1-SNAPSHOT to 0.4.0-SNAPSHOT, indicating a minor release. This aligns with the changes made in this PR.

Could you please provide more details on the planned release timeline and any significant changes that justify this minor version increment?

---

52-54: Dependency update approved. Verify changelog for breaking changes.

The update of commons-text from 1.11.0 to 1.12.0 is a good practice for maintaining up-to-date dependencies.

Please ensure you've reviewed the changelog for commons-text 1.12.0 to confirm there are no breaking changes that could affect the project. You can find the changelog at: https://commons.apache.org/proper/commons-text/changes-report.html

---

68-73: JUnit Jupiter addition approved, but consider migration strategy.

The addition of JUnit Jupiter (JUnit 5) is a good step towards modernizing the test suite. However, I noticed that the project still depends on JUnit 4.

Consider the following:

1. Is there a plan to migrate all tests to JUnit 5?
2. If so, can we start removing JUnit 4 dependencies?
3. If not, are there specific reasons for maintaining both JUnit 4 and 5 in the project?

Please clarify the testing strategy to ensure we're not unnecessarily maintaining two testing frameworks.

---

109-116: Central publishing plugin change approved. Verify publishing process.

The replacement of nexus-staging-maven-plugin with central-publishing-maven-plugin aligns with the PR objective of migrating to Central. The configuration looks appropriate for publishing to Maven Central.

To ensure a smooth transition:

1. Have you tested the publishing process in a staging environment?
2. Are there any additional steps or documentation updates needed for the team to use this new publishing method?
3. Consider adding a comment in the POM explaining the reason for this change, to help future maintainers.

---

130-130: Maven source plugin update approved. Ensure build process is tested.

Updating maven-source-plugin from 2.2.1 to 3.3.1 is a significant version jump that likely includes many improvements and bug fixes.

Please ensure that:

1. The full build process has been tested with this new version.
2. The generated source JAR is correctly created and includes all necessary files.
3. There are no unexpected changes in the build output or behavior.

---

143-143: Maven Javadoc plugin update approved. Verify Javadoc generation.

The update of maven-javadoc-plugin from 2.9.1 to 3.6.3 is a significant upgrade that likely includes better support for modern Java features and numerous improvements.

Please ensure that:

1. The Javadoc generation process completes successfully without any new warnings or errors.
2. The generated Javadoc content is correct and properly formatted.
3. If you're using any custom Javadoc tags or configurations, verify that they still work as expected with the new version.

---

Line range hint 180-180: Maven PMD plugin update approved. Run PMD to check for new findings.

Updating maven-pmd-plugin from 3.21.0 to 3.22.0 is a good practice to ensure you're using the latest rules and bug detections.

To ensure this update doesn't introduce any unexpected issues:

1. Run PMD on your codebase and compare the results with the previous version.
2. Check if there are any new findings or rule violations introduced by this update.
3. If new issues are found, assess whether they are genuine problems that need addressing or if they require rule adjustments.

---

Line range hint 1-184: Overall POM changes look good. Verify build and release process.

The changes in this POM file align well with the PR objectives. Here's a summary of the key points:

1. Project version updated to 0.4.0-SNAPSHOT, indicating a minor release.
2. Dependencies and plugins have been updated to more recent versions, which is a good practice for security and feature improvements.
3. The addition of JUnit Jupiter alongside JUnit 4 suggests a transition in the testing framework.
4. The switch to central-publishing-maven-plugin aligns with the goal of migrating to Maven Central.

These changes collectively modernize the project's build configuration and prepare it for release to Maven Central.

Before merging this PR, please ensure:

1. The entire build process, including test execution, Javadoc generation, and PMD analysis, completes successfully with these changes.
2. The new central publishing process has been tested in a staging environment.
3. All team members are aware of the new release process and any necessary documentation has been updated.
4. Consider adding comments in the POM for significant changes (like the publishing plugin switch) to aid future maintenance.

Great work on updating the project's configuration! These changes should help improve the development and release process.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.61%. Comparing base (cd92ff0) to head (906b756).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage     72.61%   72.61%           
  Complexity      220      220           
=========================================
  Files            25       25           
  Lines           712      712           
  Branches         64       64           
=========================================
  Hits            517      517           
  Misses          159      159           
  Partials         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.