Add an Option to Redownload Winetricks

[thw26]

This commit fixes #4.

It also places the TUI app in a while loop and moves the quick launch code behind an if GUI check.

Depends on #29.

[n8marti]

I need to figure out how to place my comments so the correct lines are previewed with them. Sorry about the mismatches above. They're easier to follow if you open the "Files Changed" tab.

Maybe we need to think through the logic of main a little bit more at a bigger-picture level. The CLI options in some cases preselect choices that would be found later in the TUI or GUI (e.g. SKIP_FONTS), but in other cases they completely override the need for the UI (e.g. --run-winetricks). This is why I added the ACTIONS variable. It served to short-circuit the UIs when this kind of non-interface "action" was requested from the CLI. So my knee-jerk reaction is to say "just put it back", but then that would mess up being able to put the TUI menu into a loop, which is a good idea.

But maybe the if config.DIALOG is None or config.DIALOG == 'tk': block (L197-L201) could be moved up and out of the if config.GUI is False block, along with the "actions" block (L167-L180), then the if config.GUI is True|False parts could be reverted while the curses block could just start with:

if config.DIALOG == 'curses':
    while True:
        [...]

This was an elif statement originally. Would something like that work?

[thw26]

Thanks for the review. I will rebase and then try to fix up what you've shared.

[thw26]

Rebased. Now need to review and fix up your comments.

[thw26]

@n8marti, this should be ready for a new review.

[thw26]

Also, perhaps we can do a voice call to rethink the optargs/logic of main. I will open a discussion for this, see #34.

[n8marti]

I think this PR is dependent on the outcome of #34, unless the scope is reduced to only add the new --get-winetricks and --run-winetricks options but not yet implement them.

[thw26]

I think this PR is dependent on the outcome of #34, unless the scope is reduced to only add the new --get-winetricks and --run-winetricks options but not yet implement them.

Yes, agreed. I will push the syntax fix, and then we can discuss how we want to split optargs that are for runtime config and optargs that are actionable.

[thw26]

Squashed and pushed these modifications.

I will merge this change, then we can merge the reinstall dependencies code, then we can discuss how best to handle the variable optargs and the action optargs.