Merge main into unittests #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix incorrect commands with Ubuntu prereq installer - Update maximum allowed Logos version
corrected icu-win.tar.gz filename from icu.tar.gz
- Fix incorrect commands with Ubuntu prereq installer - Update maximum allowed Logos version
Pros: - removes need for state file - doesn't rely on the name of the released icu tarball - similar handling to how we download the Logos msi installer today Cons: - ? Fixes: FaithLife-Community#220
ctrlaltf24
force-pushed
the
merge-main-into-unittests
branch
from
16a515e to
2522382
Compare
|
Force pushed to combine all three merge commits into one, no additional manual edits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.