FD-101194 - Add support for tsconfig.json files that have an extends
property
#1
+54
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we tried to run
danger
with an extendedtsconfig.json
we ran into issues. Tracked it down to this issue on thedanger-js
repo danger#1283.Following what was suggested in the issue to mimic what
ts-node
is doing to resolve thetsconfig.json
here.Their method is quite a bit more complex since they need to resolve custom
ts-node
compiler options.For our purposes, reading the config file using
ts.readConfigFile
and then parsing it withts.parseJsonConfigFileContent
produces the expectedtsconfig.json
even when it extends another one.