Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FD-101194 - Add support for tsconfig.json files that have an extends property #1

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

Jtupiter
Copy link
Collaborator

When we tried to run danger with an extended tsconfig.json we ran into issues. Tracked it down to this issue on the danger-js repo danger#1283.

Following what was suggested in the issue to mimic what ts-node is doing to resolve the tsconfig.json here.
Their method is quite a bit more complex since they need to resolve custom ts-node compiler options.

For our purposes, reading the config file using ts.readConfigFile and then parsing it with ts.parseJsonConfigFileContent produces the expected tsconfig.json even when it extends another one.

@Jtupiter Jtupiter merged commit 5edfe63 into main Sep 22, 2022
@Jtupiter Jtupiter deleted the jtupiter/FixExtendedTsconfigs branch September 22, 2022 20:00
@lukebjerring lukebjerring changed the title Add support for tsconfig.json files that have an extends property FD-101194 - Add support for tsconfig.json files that have an extends property Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants