Added marked dates lists for EasyInfiniteDateTimeLine widget #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSeednov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for your package, it's awesome!
But I found thaw it's not so easy to mark several dates with special styles - this issue is exactly about it. Yes, we can use item builder, but in that case we need to recreate all styles. It's not fast and comfortable.
I tried to improve this case, but only for EasyInfiniteDateTimeLine (at least for now): I added new property markedDatesList with possibility to change every day style for just a several dates. It can be only background color, or full day style with decoration and text styles. To provide it I also changed brightness processing: now brightness takes by final background color, not only active color. So activeDateColor is deprecated and I removed it - final text color (depends of brightness) will be get dynamically on _buildDayStructure function.
Maybe it will be useful for someone else, except me. If you decide to decline this PR - it's ok, I'll continue to use my own fork. But it you decide to integrate my changes, I can continue working on it and at least help you with all issues in this new functionality.
Also I updated example - final result on screenshot below