Skip to content

fix: use send_at

fix: use send_at #35

Triggered via pull request February 5, 2024 09:45
Status Success
Total duration 1m 5s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unneeded `return` statement: ublox-short-range/src/wifi/sta.rs#L201
warning: unneeded `return` statement --> ublox-short-range/src/wifi/sta.rs:201:9 | 201 | return Err(WifiConnectionError::Illegal); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 201 - return Err(WifiConnectionError::Illegal); 201 + Err(WifiConnectionError::Illegal) |
unneeded `return` statement: ublox-short-range/src/wifi/sta.rs#L149
warning: unneeded `return` statement --> ublox-short-range/src/wifi/sta.rs:149:9 | 149 | return Ok(()); | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 149 - return Ok(()); 149 + Ok(()) |
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/wifi/sta.rs#L108
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/wifi/sta.rs:108:73 | 108 | config_param: WifiStationConfig::WpaPskOrPassphrase(&pass), | ^^^^^ help: change this to: `pass` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/edm/urc.rs#L62
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/edm/urc.rs:62:77 | 62 | defmt::error!("[Parse URC Start/End byte Error] {:?}", LossyStr(&resp)); | ^^^^^ help: change this to: `resp` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/custom_digest.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/custom_digest.rs:70:51 | 70 | defmt::trace!("Digest {:?}", LossyStr(&buf)); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: ublox-short-range/src/command/custom_digest.rs#L21
warning: this expression creates a reference which is immediately dereferenced by the compiler --> ublox-short-range/src/command/custom_digest.rs:21:47 | 21 | defmt::trace!("Digest {:?}", LossyStr(&buf)); | ^^^^ help: change this to: `buf` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
use of `default` to create a unit struct: ublox-short-range/src/client.rs#L200
warning: use of `default` to create a unit struct --> ublox-short-range/src/client.rs:200:51 | 200 | buffers.split_blocking(tx, EdmDigester::default(), atat::Config::default()); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
value assigned to `peer_handle` is never read: ublox-short-range/src/wifi/udp_stack.rs#L64
warning: value assigned to `peer_handle` is never read --> ublox-short-range/src/wifi/udp_stack.rs:64:17 | 64 | let mut peer_handle = crate::command::PeerHandle(0); | ^^^^^^^^^^^ | = help: maybe it is overwritten before being read? = note: `#[warn(unused_assignments)]` on by default
unused variable: `e`: ublox-short-range/src/command/wifi/mod.rs#L63
warning: unused variable: `e` --> ublox-short-range/src/command/wifi/mod.rs:63:73 | 63 | atat::serde_at::from_slice::<NoResponse>(resp).map_err(|e| atat::Error::Parse) | ^ help: if this is intentional, prefix it with an underscore: `_e` | = note: `#[warn(unused_variables)]` on by default
unneeded unit expression: ublox-short-range/src/wifi/tcp_stack.rs#L224
warning: unneeded unit expression --> ublox-short-range/src/wifi/tcp_stack.rs:224:33 | 224 | ... () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
redundant field names in struct initialization: ublox-short-range/src/client.rs#L373
warning: redundant field names in struct initialization --> ublox-short-range/src/client.rs:373:29 | 373 | ... ssid: ssid, | ^^^^^^^^^^ help: replace it with: `ssid` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build & Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build & Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/