Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map changes to block pointers in 1.20.2 pre-release 4 #3664

Closed

Conversation

haykam821
Copy link
Contributor

No description provided.

@haykam821 haykam821 added refactor A PR that renames existing names. new A PR that maps mainly new names snapshot A PR that targets a snapshot version of Minecraft labels Sep 13, 2023
@haykam821 haykam821 requested a review from a team September 13, 2023 21:04
Comment on lines +3 to +5
FIELD comp_1968 pos Lnet/minecraft/class_2338;
FIELD comp_1969 state Lnet/minecraft/class_2680;
FIELD comp_1970 blockEntity Lnet/minecraft/class_2601;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't need to be mapped, do they? The names are exactly the same for these three with name proposal (obviously we want to keep the change from level to world though)

@Shnupbups Shnupbups mentioned this pull request Sep 15, 2023
@apple502j apple502j closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new A PR that maps mainly new names refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants