Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SkullItem to PlayerHeadItem #3658

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Rename SkullItem to PlayerHeadItem #3658

merged 3 commits into from
Sep 12, 2023

Conversation

YanisBft
Copy link
Contributor

@YanisBft YanisBft commented Sep 8, 2023

Is now only used by player heads

@YanisBft YanisBft added the refactor A PR that renames existing names. label Sep 8, 2023
Shnupbups
Shnupbups previously approved these changes Sep 9, 2023
View reviewed changes
@Shnupbups Shnupbups requested a review from a team September 9, 2023 15:55
@YanisBft YanisBft changed the base branch from 1.20.2-pre2 to 1.20.2-pre3 September 12, 2023 13:44
@YanisBft YanisBft dismissed Shnupbups’s stale review September 12, 2023 13:44

The base branch was changed.

@Shnupbups Shnupbups requested a review from a team September 12, 2023 14:02
@apple502j
Copy link
Contributor

Seems not impactful, merging.

@apple502j apple502j merged commit b8bd54a into FabricMC:1.20.2-pre3 Sep 12, 2023
3 checks passed
@YanisBft YanisBft deleted the fix/skull-item branch September 12, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haykam821 haykam821 haykam821 approved these changes

@Shnupbups Shnupbups Shnupbups approved these changes

Assignees
No one assigned
Labels
refactor A PR that renames existing names.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YanisBft @apple502j @Shnupbups @haykam821