Add tag aliases #4198
Merged
Add tag aliases #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
added
enhancement
apple502j
reviewed
Nov 24, 2024
...tion-api-v1/src/main/java/net/fabricmc/fabric/api/datagen/v1/provider/FabricTagProvider.java
Outdated
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/impl/tag/TagAliasLoader.java
Show resolved
Hide resolved
modmuss50
reviewed
Nov 25, 2024
...tion-api-v1/src/main/java/net/fabricmc/fabric/api/datagen/v1/provider/FabricTagProvider.java
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/api/tag/v1/TagAliasGroup.java
Outdated
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/api/tag/v1/TagAliasGroup.java
Outdated
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/impl/tag/TagAliasLoader.java
Outdated
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/mixin/tag/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/mixin/tag/SimpleRegistryMixin.java
Outdated
Show resolved
Hide resolved
# Conflicts: # gradle.properties
modmuss50
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
This looks good to me. Just one or two minor nit picks. Ill move to last call now (expect a full week).
@TelepathicGrunt would you be able to take a quick look at the readme/package doc to make sure that it covers your use cases/looks reasonable.
fabric-tag-api-v1/src/main/java/net/fabricmc/fabric/api/tag/v1/TagAliasGroup.java
Outdated
Show resolved
Hide resolved
TelepathicGrunt
approved these changes
Dec 6, 2024
modmuss50
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Add tag aliases * Document and rename tag alias internals * Make the tag alias directory singular to match Mojang's recent style * Add a note about tag aliases to client tag documentation * Support missing tags in alias groups * Support tag aliases for dynamic and reloadable registries * TagAliasGroup: Document naming conventions for c tag alias groups * Add tag alias test mod * Fix inline return checkstyle * Add test for tag alias data generation * Fix checkstyle (again) * Add tag translations to tag API testmod * Uncomment accidentally commented out code * SimpleRegistryMixin: Improve a log message * TagAliasTest: Improve assertion messages * Fix tag aliases for dynamic registries not applying on /reload * Clean up log message once again * Address review feedback * Make missing interfaces throw CCEs * Add README * Move TagAliasGroup into the impl package (cherry picked from commit a730659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag alias API lets modders merge different but equivalent tags together so that they have the same content. For example, tag aliases can be used to unify matching
minecraftandctags. (This is the main purpose of the PR.)Tag aliases are defined in data packs like tags. For example, a block tag alias group for fences would be located at
data/my_mod/fabric/tag_aliases/block/fences.jsonwith the contents:{ "tags": [ "minecraft:fences", "c:fences" ] }The files can also be generated with the data generation API. Alias groups can be replaced (or disabled) like most data pack files by having a different file with the same name at the same file path.
TODO: