Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR could be a bit more controversial so let it sit for a bit. On Neoforge, I am proposing an Experience fluid tag and figured it might be a good time to try and propose the missing fluid tags to Fabric if Fabric is ok with them.
The fluid tags were originally in long past, tags that mods in that ecosystem used to have. So there were lots of people with stuff like potion fluids or experience fluids and they tried to agree upon a standard for bottle/bowl rates to buckets for said tags. I am not sure how common these stuff are in fabric's ecosystem or what the agreed upon rates are.
According to the FluidConstants class, fabric ecosystem is 3 bottles to 1 bucket so people are expecting 27000 droplet for bottles and bowls. I added the FluidConstant class in the javadocs for the fluid tags class so new modders know what other modders are expecting when they find a fluid that matches the tag. I also added bowls to the FluidConstants class (assuming it is equal to bottles) so there is less confusions around bowls. But I can remove this new constant if preferred.
I also state in the Javadoc how to get what the potion type is for potion fluids and suspicious stew fluids by using data components (to help make mods know how to interact with each other)
For the experience fluid rate, that one is tricky. After some research, we found these fabric mods with Experience Fluids at different rates:
Kibe: 810 droplets to 1 xp
Create Enchantment Industry: 81 droplet to 1 xp and 81 droplet to 10 xp
XP Obelisk: 810 droplets to 1 xp
Sophisticated Core: 1620 droplets to 1 xp
So I went 810 droplet rate unless those devs decide in Fabric discord that they want a different rate. 810 seems to be a compromise in the middle of these mods. Standardizing the rate will help multiple mods with experience fluid to know how to read each other's volume of fluids properly.