AttachmentType Registration Enhancements #4109
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register
AttachmentType
s using the builder with consumer pattern.Today, using the builder pattern creates a
Builder<Object>
by default, making both thepersistent
method and theinitializer
method largely useless, which is especially problematic as this is currently the only way to create an attachment with both persistence and a default value.While this can be avoided by explicitly providing type parameters to the static
AttachmentRegistry#builder
method, type parameterizing methods is unintuitive and should be avoided as an API pattern whenever possible.The solution implemented in this PR is the addition of the
AttachmentRegistry#create(Identifier id, Consumer<Builder<A>>)
method. This allows users to configure the (better type inferred) builder directly.