Fix new tags not being plural #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haykam821
suggested changes
Jun 12, 2024
...on-tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
Outdated
Show resolved
Hide resolved
...java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java
Outdated
Show resolved
Hide resolved
...java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java
Outdated
Show resolved
Hide resolved
...java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java
Outdated
Show resolved
Hide resolved
...java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java
Outdated
Show resolved
Hide resolved
…i/tag/convention/v2/ConventionalItemTags.java Co-authored-by: haykam821 <[email protected]>
…/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java Co-authored-by: haykam821 <[email protected]>
…/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java Co-authored-by: haykam821 <[email protected]>
…/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java Co-authored-by: haykam821 <[email protected]>
…/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java Co-authored-by: haykam821 <[email protected]>
|
@modmuss50 any concerns or is this good for approval? |
Sorry, been a bit busy (IRL things, and porting my mod to 1.21 :D ). Ill try and take ASAP. |
modmuss50
added
bug
modmuss50
approved these changes
Jun 17, 2024
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely my fault. I should've caught the typoes. Gave them the same treatment as the tool tags of deprecating the typoed stuff
Fixes #3807
Matches neoforged/NeoForge#1030