TooltipDataCallback (copy of #3403 using Mixin Extras) #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient/rendering/v1/TooltipComponentCallback.java Co-authored-by: Juuz <[email protected]>
…ient/rendering/v1/TooltipDataCallback.java Co-authored-by: Juuz <[email protected]>
It happened when only one tooltip data is added by event handlers I for some reason assumed that there is always original data in item
…client/rendering/HandledScreenMixin.java Co-authored-by: Juuz <[email protected]>
modmuss50
approved these changes
Dec 28, 2023
modmuss50
added
last call
modmuss50
requested changes
Jan 5, 2024
Comment on lines
+38
to
+42
| var multiData = new MultiTooltipData(new ArrayList<>()); | ||
| TooltipDataCallback.EVENT.invoker().appendTooltipData(stack, multiData.tooltipData()); | ||
|
|
||
| if (multiData.tooltipData().isEmpty()) { | ||
| return original.call(stack); |
There was a problem hiding this comment.
This behaves diffrently to the other PR. Whats the expected behaviour?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3403 (comment)