Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only retain buffer on receiving side #3446

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Only retain buffer on receiving side #3446

merged 1 commit into from
Nov 27, 2023

Conversation

deirn
Copy link
Member

@deirn deirn commented Nov 27, 2023

Resolves #3445

@deirn deirn added bug Something isn't working fabric-networking Pull requests and issues related to the networking api priority:high High priority PRs that need review and work now. Review these first. labels Nov 27, 2023
@deirn deirn requested review from a team November 27, 2023 04:20
@deirn deirn force-pushed the mooned-shopper-wildcard branch from 8f1605a to 2432bff Compare November 27, 2023 04:39
modmuss50
modmuss50 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, many thanks for fixing this so quickly. I will get this released shortly.

@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Nov 27, 2023
@modmuss50 modmuss50 merged commit e3b6950 into FabricMC:1.20.2 Nov 27, 2023
5 checks passed
modmuss50 pushed a commit that referenced this pull request Nov 27, 2023
@deirn @modmuss50
Only retain buffer on receiving side (#3446)
901470e 
(cherry picked from commit e3b6950)
@leetfin
Copy link

leetfin commented Nov 27, 2023

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fabric-networking Pull requests and issues related to the networking api merge me please Pull requests that are ready to merge priority:high High priority PRs that need review and work now. Review these first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deirn @leetfin @modmuss50