Fix registry resource conditions on loot tables. #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is as simple as storing the DRM in a normal field rather than in ThreadLocal. |
modmuss50
added a commit
that referenced
this pull request
Nov 26, 2023
* Fix registry resource conditions on loot tables. * assert we dont already have the DRM set on this thread. * Use a sync map (cherry picked from commit de5c6cc)
modmuss50
added a commit
that referenced
this pull request
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone has a better idea for passing the DRM instance to the load method please let me know. Closes #3322