Fix FluidStorageUtil#moveWithSound Play Sound
#3431
Conversation
| @@ -111,7 +111,7 @@ private static boolean moveWithSound(Storage<FluidVariant> from, Storage<FluidVa | |||
| if (!fill && handItem == Items.POTION) sound = SoundEvents.ITEM_BOTTLE_EMPTY; | |||
| } | |||
|
|
|||
| player.playSound(sound, SoundCategory.BLOCKS, 1, 1); | |||
| player.getWorld().playSound(player, player.getX(), player.getEyeY(), player.getZ(), sound, SoundCategory.PLAYERS, 1, 1); | |||
There was a problem hiding this comment.
Has this been tested, I believe you need to pass null as the first param otherwise this is going to play for everyone BUT the player.
There was a problem hiding this comment.
This method should be called both on client and server. ClientWorld.playSound will play sound to the except, while ServerWorld.playSound will play sound to all players but the except. This usage is according to vanilla usage, such as FenceGateBlock#onUse.
There was a problem hiding this comment.
Humm, I tested with the chute block in the FAPI test mods, they only call this on the server. I wonder if its worth wrappning this is a !world.isClient? Maybe @Technici4n would have some input on this?
There was a problem hiding this comment.
Well it depends on which side modders are expected to call it. It's probably worth documenting.
There was a problem hiding this comment.
Yes, you were right, it makes sense to call this on both sides. I have gone ahead and updated the testmod, this now works as expected. 👍
There was a problem hiding this comment.
Should we indicate it needs to be called on both sides in the doc?
...ransfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/fluid/FluidStorageUtil.java
Show resolved
Hide resolved
…ransfer/v1/fluid/FluidStorageUtil.java
* fix play sound * Update fabric-transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/fluid/FluidStorageUtil.java * Fix chute testmod --------- Co-authored-by: modmuss <[email protected]> (cherry picked from commit 4944b5a)
It plays sound to all players only once now.