Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty storage iterator returning views that become empty during i… #3423

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix empty storage iterator returning views that become empty during i… #3423

merged 1 commit into from
Nov 26, 2023

Conversation

Technici4n
Copy link
Member

Moral of the story: use Guava instead of rolling your own stuff.

Fixes #3414.

@Juuxel Juuxel added bug Something isn't working small change labels Nov 14, 2023
@modmuss50 modmuss50 added the merge me please Pull requests that are ready to merge label Nov 19, 2023
@modmuss50 modmuss50 merged commit aaf9c96 into FabricMC:1.20.3 Nov 26, 2023
5 checks passed
modmuss50 pushed a commit that referenced this pull request Nov 26, 2023
@Technici4n @modmuss50
Fix empty storage iterator returning views that become empty during i…
9ab11d5 
…teration (#3423)

(cherry picked from commit aaf9c96)
modmuss50 pushed a commit that referenced this pull request Nov 26, 2023
@Technici4n @modmuss50
Fix empty storage iterator returning views that become empty during i…
c81d263 
…teration (#3423)

(cherry picked from commit aaf9c96)
(cherry picked from commit 9ab11d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juuxel Juuxel Juuxel approved these changes

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge me please Pull requests that are ready to merge small change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer api bug: nonEmptyIterator doesn't handle views that become empty during iteration
3 participants
@Technici4n @modmuss50 @Juuxel