23w45a porting fixes #3421
Merged
23w45a porting fixes #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also request Object Builder minor version to be bumped, as we did not when we added wind charge field in the initial port. |
Shnupbups
approved these changes
Nov 13, 2023
Technici4n
approved these changes
Nov 14, 2023
modmuss50
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openableByWindChargenot being copied. Testing this the easy way (copying vanilla) turned out to be a little difficult because you have to compareBlockSetType, and the ID field has a colon when constructing with our builder.