-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #2901 to 1.19.2 #3413
Backport #2901 to 1.19.2 #3413
Conversation
* Add registry for core shaders in custom namespaces * Apply suggestions from code review Co-authored-by: modmuss50 <[email protected]> * Use Identifier.NAMESPACE_SEPARATOR instead of ":" * Remove fabric_ prefixes from mixins * Move test rendering to lower-right corner for test screenshots --------- Co-authored-by: modmuss50 <[email protected]>
I think its unlikely that we will backport this to 1.18.2, but 1.19.2 should be possible, is there anything else (anyone) may want backporting while we are at it? |
...endering-v1/src/testmod/java/net/fabricmc/fabric/test/rendering/client/HudAndShaderTest.java
Outdated
Show resolved
Hide resolved
I’ll try to backport this to 1.18.2 after this PR is merged. Right now, I’d also prefer to have the |
8d46a67
to
c2b7aa6
Compare
Im a little hesitant to do a 1.18.2 feature release as its bene so long, and is before we split making it a bit hard to backport, I guess we can? If so It would need to go in at the same time as this PR. |
This PR backports the core shader API in
fabric-rendering-v1
to 1.19.2. This consists mostly of renames of the 1.19.3 API’s code, plus a minor change in the test mod to use the pre-JOMLMatrix4f
.Motivation
While I want to use the standard Forge and Fabric APIs for custom core shaders in Caxton, Fabric’s APIs are not available on 1.19.2 or 1.18.2, both of which Caxton still supports.