Fix Doubles not being editable in the game-rule menu #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
By the way, I noticed DoubleRule is the only one that implements |
It can't due to remapping (the method would not be available in production). |
Technici4n
approved these changes
Oct 30, 2023
modmuss50
approved these changes
Oct 30, 2023
modmuss50
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Fix double gamerules rules not being editable in menu * Updated `validate`'s javadoc (cherry picked from commit a44e16a)
modmuss50
pushed a commit
that referenced
this pull request
Nov 2, 2023
modmuss50
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Fix double gamerules rules not being editable in menu * Updated `validate`'s javadoc (cherry picked from commit a44e16a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently, game-rules of type Double are impossible to edit using the "Edit Gamerules" screen on world creation; any change to those rules is discarded upon exiting the screen.
This is due to
DoubleRule.validatenot updating the rule's value when called by theDoubleRuleWidget. For other gamerule types, this is how their widget update their value.I have tested the fix in this PR on 1.20.2 using the artifacts generated on my fork. However the issue dates from furher back; at least since 1.19.4 where I first identified the issue. If this is accepted, I'd be interested in a backport of this fix to that version.