Fix inconsistency of placed feature locations #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BiomeSource#getBiomes` mixin applies to all biome sources, including one for Overworld. The return value is a set; however one caller in the worldgen code iterates over it: `PlacedFeatureIndexer`. Using a hash set here randomizes the return value, affecting feature placement. Use a linked hash set instead.
apple502j
added
bug
modmuss50
reviewed
Oct 7, 2023
fabric-biome-api-v1/src/main/java/net/fabricmc/fabric/mixin/biome/BiomeSourceMixin.java
Outdated
Show resolved
Hide resolved
modmuss50
pushed a commit
that referenced
this pull request
Oct 8, 2023
* Fix inconsistency of placed feature locations `BiomeSource#getBiomes` mixin applies to all biome sources, including one for Overworld. The return value is a set; however one caller in the worldgen code iterates over it: `PlacedFeatureIndexer`. Using a hash set here randomizes the return value, affecting feature placement. Use a linked hash set instead. * Improve fix to only make changes when required. --------- Co-authored-by: modmuss50 <[email protected]> (cherry picked from commit 661cc8c)
modmuss50
pushed a commit
that referenced
this pull request
Oct 8, 2023
* Fix inconsistency of placed feature locations `BiomeSource#getBiomes` mixin applies to all biome sources, including one for Overworld. The return value is a set; however one caller in the worldgen code iterates over it: `PlacedFeatureIndexer`. Using a hash set here randomizes the return value, affecting feature placement. Use a linked hash set instead. * Improve fix to only make changes when required. --------- Co-authored-by: modmuss50 <[email protected]> (cherry picked from commit 661cc8c)
modmuss50
pushed a commit
that referenced
this pull request
Oct 8, 2023
* Fix inconsistency of placed feature locations `BiomeSource#getBiomes` mixin applies to all biome sources, including one for Overworld. The return value is a set; however one caller in the worldgen code iterates over it: `PlacedFeatureIndexer`. Using a hash set here randomizes the return value, affecting feature placement. Use a linked hash set instead. * Improve fix to only make changes when required. --------- Co-authored-by: modmuss50 <[email protected]> (cherry picked from commit 661cc8c) (cherry picked from commit 215bbe9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BiomeSource#getBiomesmixin applies to all biome sources, including one for Overworld. The return value is a set; however one caller in the worldgen code iterates over it:PlacedFeatureIndexer. Using a hash set here randomizes the return value, affecting feature placement. Use a linked hash set instead.Requesting backport for all supported versions.
Fixes #3366