Add LootTableEvents.LOADED event #3352
Conversation
|
General question, whats the use case for this event? I see the test mod is only checking that loot table is not empty, I imagine you plan to do more with it? |
Yes. I want to add loot table modification to LootJS and I want to trigger the LootJS event when all loot tables are loaded and modified by mods. So packdevs can further modify them by their needs. |
| * @param resourceManager the server resource manager | ||
| * @param lootManager the loot manager | ||
| */ | ||
| void onLootTableLoaded(ResourceManager resourceManager, LootManager lootManager); |
There was a problem hiding this comment.
| void onLootTableLoaded(ResourceManager resourceManager, LootManager lootManager); | |
| void onLootTablesLoaded(ResourceManager resourceManager, LootManager lootManager); |
technically there's multiple of them? :P
There was a problem hiding this comment.
Maybe then this event should be called ALL_LOADED? Previous events are called per loot table, so the new event may be confusing.
Also I think this event should be after the MODIFY/REPLACE events in the code, but that does not matter, it is about checkstyle.
Btw, this event is very similar to CommonLifecycleEvents.TAGS_LOADED
There was a problem hiding this comment.
Also I think this event should be after the MODIFY/REPLACE events in the code, but that does not matter, it is about checkstyle.
wdym by that?
There was a problem hiding this comment.
wdym by that?
Ah, sorry, nevermind. I am inattentive
fabric-loot-api-v2/src/main/java/net/fabricmc/fabric/api/loot/v2/LootTableEvents.java
Outdated
Show resolved
Hide resolved
…v2/LootTableEvents.java Co-authored-by: Juuz <[email protected]>
* Implement `LootTableEvents.LOADED` event * Update for checkstyle * rename event * Update fabric-loot-api-v2/src/main/java/net/fabricmc/fabric/api/loot/v2/LootTableEvents.java Co-authored-by: Juuz <[email protected]> --------- Co-authored-by: modmuss <[email protected]> Co-authored-by: Juuz <[email protected]> (cherry picked from commit 96dfa95)
* Implement `LootTableEvents.LOADED` event * Update for checkstyle * rename event * Update fabric-loot-api-v2/src/main/java/net/fabricmc/fabric/api/loot/v2/LootTableEvents.java Co-authored-by: Juuz <[email protected]> --------- Co-authored-by: modmuss <[email protected]> Co-authored-by: Juuz <[email protected]> (cherry picked from commit 96dfa95) (cherry picked from commit 3ba460f)
Hey,
The current loot table mixin https://github.com/FabricMC/fabric/blob/1.20.1/fabric-loot-api-v2/src/main/java/net/fabricmc/fabric/mixin/loot/LootManagerMixin.java#L55 updates the return value which will automatically blocks all modded mixins with the same injection but higher priority.
So I added an event which can be used to track down when all loot tables are loaded + modified by fabric events.
My first idea was to move the mixin to
applyagain like in previous versions but the current mixin requires theResourceManagerwhich does not exist inapplyand I wasn't sure if collecting theResourceManagerfirst, storing it in the class and passing it later on is a preferable way for fabric.