Pass handler to clientside ConfigurationPacketHandler #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
added
enhancement
|
Question: why is the handler useful? |
|
Closing, on second thought this doesn't look like it's needed in many use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change, needs to be merged ASAP.
Turns out you cannot query CCNH from MinecraftClient. We first need to get ClientConnection (which is also PITA - the impl already does that elsewhere), then get the handler through Netty internals and several casting.
Also adds a helper method to disconnect, as there is currently no way to do so. I wasn't sure if interface injection or static method was better; you can revert the commit if this needs to be discussed later.