Transfer API: Add slotted storage and non-empty iterator #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/item/InventoryStorage.java
Show resolved
Hide resolved
SquidDev
reviewed
Mar 15, 2023
...ransfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/storage/SlottedStorage.java
Show resolved
Hide resolved
Technici4n
force-pushed
the
trapi-additions
branch
from
474ff78 to
7df5541
Compare
… UnmodifiableView annotations
Technici4n
force-pushed
the
trapi-additions
branch
from
7df5541 to
a8e836a
Compare
Juuxel
suggested changes
Mar 31, 2023
...transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/item/InventoryStorage.java
Outdated
Show resolved
Hide resolved
...transfer-api-v1/src/main/java/net/fabricmc/fabric/api/transfer/v1/item/InventoryStorage.java
Outdated
Show resolved
Hide resolved
| * for example {@link StorageUtil#insertStacking} or {@link ContainerItemContext#getAdditionalSlots()}. | ||
| * | ||
| * <p>It is guaranteed that calling this function is fast. | ||
| * The default implementation returns a view over the storage that delegates to {@link #getSlotCount} and {@link #getSlot}. |
There was a problem hiding this comment.
Do we have @implSpec here for specifying the default impl? (Yarn adds it to its list of javadoc tags at least)
There was a problem hiding this comment.
(They just vanish if you run gradlew javadoc...)
There was a problem hiding this comment.
Probably a good improvement for a future PR, they're really easy to add:
https://github.com/FabricMC/yarn/blob/4eed62e0827b13c25af0a5b1262fb204c9ddbf52/build.gradle#L554-L558
Juuxel
approved these changes
Mar 31, 2023
modmuss50
approved these changes
Apr 2, 2023
modmuss50
reviewed
Apr 2, 2023
fabric-transfer-api-v1/src/main/java/net/fabricmc/fabric/impl/transfer/TransferApiImpl.java
Outdated
Show resolved
Hide resolved
modmuss50
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Transfer API: Add non-empty iterator * Add SlottedStorage * Add StorageUtil.extractAny * Undeprecate ContainerItemContext.withInitial * Add licenses * Revert "Undeprecate ContainerItemContext.withInitial" This reverts commit dcf123e. * Tweaks * Make SlottedStorage#getSlots return a view, remove useless field, add UnmodifiableView annotations * Remove useless @inheritdoc * Fix infinite loop in the tests
qouteall
pushed a commit
to qouteall/fabric
that referenced
this pull request
May 3, 2023
* Transfer API: Add non-empty iterator * Add SlottedStorage * Add StorageUtil.extractAny * Undeprecate ContainerItemContext.withInitial * Add licenses * Revert "Undeprecate ContainerItemContext.withInitial" This reverts commit dcf123e. * Tweaks * Make SlottedStorage#getSlots return a view, remove useless field, add UnmodifiableView annotations * Remove useless @inheritdoc * Fix infinite loop in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageUtil.extractAny.SlottedStoragethat allows storages to optionally expose a slot list. This is optional, and is meant for usage by chest-like inventories.SingleVariantStorage#getBlankVariant.TransferApiImpl.None of these should be breaking changes.