Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Non functional] fabric-resource-conditions-api-v1 #3322

Closed
xanthian opened this issue Sep 17, 2023 · 5 comments · Fixed by #3432
Closed

[Non functional] fabric-resource-conditions-api-v1 #3322

xanthian opened this issue Sep 17, 2023 · 5 comments · Fixed by #3432
Labels
bug Something isn't working

Comments

@xanthian
Copy link

Seems that the fabric:registry_contains is non functional for loot tables.

Reasoning behind the claim :

When the following is present in loot_table json file

"condition": "fabric:registry_contains",
"registry": "minecraft:block",
"values": [
"modid:block_name"

You get the following error in console :
(Fabric Resource Conditions) Can't retrieve current registries. Failing registry_contains resource condition check.
this occurs if the block is present or not.
Game loads fine, no further console errors regarding the loot table json, however the loot table does not function (no item drops)

Removing the fabric:registry_contains does allow the loot to drop, but for the niche case i'm using it for (to stop console spam when another mod's block is not present - i'm already checking the mod is present)
if the block is not present you get the console error as expected
Couldn't parse element loot_tables:mymodid:blocks/missing_block_name

fabric_version=0.88.1+1.20.1
minecraft_version=1.20.1
yarn_mappings=1.20.1+build.10
loader_version=0.14.22
'fabric-loom' version '1.3-SNAPSHOT'

@xanthian
Copy link
Author

In testing further (and trying to get my mod to function) it seems the tags_populated also doesnt work :(
Can't retrieve deserialized tags. Failing tags_populated resource condition check.

@apple502j
Copy link
Contributor

These two are somewhat different, in what is causing the issue:

@xanthian
Copy link
Author

Someone mentioned thread issue, although I have no clue what that means 👍🏼
Does it mean its not likely to be resolved / any time soon?

@xanthian
Copy link
Author

Any movement on this at all? 🤞

@xanthian
Copy link
Author

xanthian commented Dec 3, 2023

This works perfectly, thankyou 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants