Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication #1082

Merged
merged 8 commits into from
May 8, 2023
Merged

Fix authentication #1082

merged 8 commits into from
May 8, 2023

Conversation

kyle-kingsbury
Copy link
Contributor

@kyle-kingsbury kyle-kingsbury commented May 5, 2023

This PR addresses a few things. in configuration->General->General Settings, changing the machine name was producing an uncaught exception because it was attempting to use an edison specific function in fabmo/network/linux/raspberry-pi/index.js. Also, there were some references to beacon which we removed a while back. Removed them.

Configuration->Users->Change Password was not working at all, nor was it allowing admin to change other users password. Any user can now change their own password, admin is the superuser and can change anyones password. Users that are assigned as admin can add users and change their password, but cannot change the superusers password. For testing:

  • Logged in as admin, changed own password, logged out and logged back in with new password
  • Logged in as admin, added a new user, logged out and logged back in as that user
  • Logged in as admin, changed password of existing user, logged out and logged back in as that user with new password
  • Logged in as user, added new user, logged out and logged back in as that user
  • Logged in as user, added new user, changed their password, logged out and logged back in as that user with new password

This PR fixes #1014 and the "no user" exception found in issue #1081.

Ran the dev checks and master branch of fabmo/fabmo-api-tests. All tests passed.

@kyle-kingsbury kyle-kingsbury requested a review from RobMackie May 5, 2023 16:40
@kyle-kingsbury kyle-kingsbury marked this pull request as ready for review May 5, 2023 16:45
Copy link
Contributor

@RobMackie RobMackie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@RobMackie
Copy link
Contributor

ran the same tests you ran (or very close to them) on my machine. I created 2 new uers, changed the password of a user as a user and as a superuser, then logged in as a user and ran the normal devchecks. All went well. It's nice that users work.

@RobMackie RobMackie merged commit 52cf9a0 into master May 8, 2023
@RobMackie RobMackie deleted the kk_auth branch May 8, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration->Users->Change password, not working
2 participants