-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve action on manual Keypad when activated from the keyboard. #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-kingsbury
approved these changes
Apr 17, 2023
Ran the dev-checks and a couple of cut files. Tested the keypad extensively: goto, set, fixed moves, continuous moves, zeroing axes, adjusting move speed with new hotkey, entered fixed mode with new hotkey, tested all with keyboard and mouse. Everything seems to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the visuals of using the Keypad from a keyboard and specifically makes the axis button illumination work the same as with a mouse for short nudges and longer holds. Issue #1058
It also adds the keyboard shortcuts suggested in Issue #1067 (toggle fixed; ">" for changing speed) including an exit by clicking anywhere outside modal keypad.
Having played with these, we might want to additionally consider the following shortcuts:
Tested with sb_logo and the SK insert of dev-tests.
Checked appearance on mobile.
I've done some keypadding around on the two tools I have. There are the occasional responsiveness irregularities in using the keypad with happy-fingers (not always triggering, or triggering more than intended). I don't think this has changed. This includes the occasional longer-than-intended move. We may want to keep our eyes out for methods to duplicate these and clean Keypadding up some more.
Note that this is extension to ongoing work and PR's. It is the last 3 commits.