Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid behaviors for points with None space #558

Open
dickscheid opened this issue Feb 7, 2024 · 2 comments
Open

Valid behaviors for points with None space #558

dickscheid opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@dickscheid
Copy link
Contributor

dickscheid commented Feb 7, 2024

siibra Point objects may - though in rare cases - have been initialized with space=None.

The current siibra implementation of Point will fail at several places, since it often assumes Point.space to be a valid Space object. For example, already __repr__ will fail since it wants to output self.space.id.

The class needs too be reviewed in this respect. Requiring space to be set is not a straightforward solution since the Point class is also used to process voxels (e.g. after .transform with an inverse affine of a NIFti template).

@dickscheid dickscheid added the bug Something isn't working label Feb 7, 2024
@AhmetNSimsek
Copy link
Collaborator

61e0623 addresses the case when a Location has space=None.

@AhmetNSimsek
Copy link
Collaborator

How about a secondary class called Voxel under point module? We could make it so that some Point operations produce a Voxel and vice versa. We could then also enable BoundingBox or PointSet (VoxelSet?) to be able to be initialized with Voxels to represent them in voxel space. What do you think?

@AhmetNSimsek AhmetNSimsek added enhancement New feature or request and removed bug Something isn't working labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants