You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
siibra Point objects may - though in rare cases - have been initialized with space=None.
The current siibra implementation of Point will fail at several places, since it often assumes Point.space to be a valid Space object. For example, already __repr__ will fail since it wants to output self.space.id.
The class needs too be reviewed in this respect. Requiring space to be set is not a straightforward solution since the Point class is also used to process voxels (e.g. after .transform with an inverse affine of a NIFti template).
The text was updated successfully, but these errors were encountered:
How about a secondary class called Voxel under point module? We could make it so that some Point operations produce a Voxel and vice versa. We could then also enable BoundingBox or PointSet (VoxelSet?) to be able to be initialized with Voxels to represent them in voxel space. What do you think?
siibra Point objects may - though in rare cases - have been initialized with
space=None
.The current siibra implementation of
Point
will fail at several places, since it often assumesPoint.space
to be a validSpace
object. For example, already__repr__
will fail since it wants to outputself.space.id
.The class needs too be reviewed in this respect. Requiring space to be set is not a straightforward solution since the Point class is also used to process voxels (e.g. after
.transform
with an inverse affine of a NIFti template).The text was updated successfully, but these errors were encountered: