Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should siibra cache be versioned? #449

Open
AhmetNSimsek opened this issue Aug 31, 2023 · 1 comment
Open

Should siibra cache be versioned? #449

AhmetNSimsek opened this issue Aug 31, 2023 · 1 comment
Assignees
Labels
caching&persistence Issues related to storing siibra objects - caching persistence and serialization. enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related.

Comments

@AhmetNSimsek
Copy link
Collaborator

For example, if there is a change in the data of a certain map but not in its name, potentially the user might not get the updated data if it was previously cached locally.

@AhmetNSimsek AhmetNSimsek added enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related. labels Aug 31, 2023
@xgui3783 xgui3783 changed the title Should siibra cahce be versioned? Should siibra cache be versioned? Aug 31, 2023
@xgui3783
Copy link
Member

my 2c, in order of preference:

  • (most favourable) leave things as they are (i.e. cache are not cleared until user specifically calls siibra.cache.clear() . Simplest solution, and easy to debug
  • (distant 2nd) tie cache to siibra version. if siibra version increments, invalidate all cache. CON: on new installation of siibra-python, if there was a version increment, the local cache will need to be populated again.

As a user of siibra-python, I would like to be able to control how/when I clear my cache:

  • with python interpreter, I would manually call siibra.cache.clear(), and I do not do this often
  • in siibra-api, new directories are used for cache for each siibra-api release, effectively "clearing the cache"

IMO, the last thing we want is to have yet one more place, where stale cache breaks our build, or overly zealous cache invalidation results in new configuration to be fetched everytime a new python session starts

@AhmetNSimsek AhmetNSimsek added the caching&persistence Issues related to storing siibra objects - caching persistence and serialization. label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caching&persistence Issues related to storing siibra objects - caching persistence and serialization. enhancement New feature or request maintenance Not a bug or breaking issue. Code maintenance related.
Projects
None yet
Development

No branches or pull requests

3 participants