Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow meshes to be exported #516

Closed
wants to merge 2 commits into from
Closed

feat: allow meshes to be exported #516

wants to merge 2 commits into from

Conversation

xgui3783
Copy link
Member

fixes #396

@codecov-commenter
Copy link

Codecov Report

Attention: 1281 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (b6fd7fa) 50.66%.
Report is 297 commits behind head on main.

Files Patch % Lines
siibra/volumes/volume.py 44.13% 119 Missing ⚠️
siibra/features/feature.py 48.09% 109 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
siibra/volumes/parcellationmap.py 18.25% 103 Missing ⚠️
siibra/core/region.py 62.34% 90 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 25.97% 57 Missing ⚠️
siibra/retrieval/datasets.py 51.81% 53 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 25.00% 48 Missing ⚠️
siibra/configuration/factory.py 54.34% 42 Missing ⚠️
... and 38 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #516       +/-   ##
===========================================
+ Coverage   36.81%   50.66%   +13.84%     
===========================================
  Files          61       71       +10     
  Lines        5421     6512     +1091     
===========================================
+ Hits         1996     3299     +1303     
+ Misses       3425     3213      -212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek marked this pull request as ready for review December 5, 2023 15:52
@AhmetNSimsek AhmetNSimsek added the enhancement New feature or request label Dec 7, 2023
@AhmetNSimsek AhmetNSimsek marked this pull request as draft December 7, 2023 13:07
@AhmetNSimsek
Copy link
Collaborator

@dickscheid is reluctant to add another requirement at the moment. We should discuss mesh support of siibra-python in general and choose a lane accordingly. This could very well be trimesh.

@AhmetNSimsek
Copy link
Collaborator

At the dev meeting on 25.01.2024, it is decided against this PR and in favor of #554 .

@AhmetNSimsek AhmetNSimsek deleted the feat_exportMeshes branch March 7, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] map.fetch() returns inconsistent type
3 participants
@xgui3783 @codecov-commenter @AhmetNSimsek